WIP, DONT MERGE #1088
Draft
WIP, DONT MERGE #1088
+10
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: eclipse-jdt#1081 Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
|
@jukzi one thing that remains the same is the I'm not sure this is the right fix, but lets see what the tests have to say. I'm also not sure how we want to test this, as commented on #1081 so far I can reproduce the stack overflow only with an unbound classpath container. Will have to check how to specify an unbound container during tests... |
jukzi
reviewed
May 24, 2023
| @@ -148,6 +149,8 @@ public class LookupEnvironment implements ProblemReasons, TypeConstants { | |||
|
|
|||
| public String moduleVersion; // ROOT_ONLY | |||
|
|
|||
| private final Set<String> acceptingSourceFiles = new HashSet<>(); | |||
There was a problem hiding this comment.
i don't know about the lifetime of LookupEnvironment., but i guess at least it should be cleared on reset()
jukzi
reviewed
May 24, 2023
| } catch (AbortCompilation abort) { | ||
| if (CharOperation.equals(name, TypeConstants.PACKAGE_INFO_NAME)) | ||
| return null; // silently, requestor may not be able to handle compilation units (HierarchyResolver) | ||
| throw abort; | ||
| } finally { | ||
| this.acceptingSourceFiles.remove(fileName); |
There was a problem hiding this comment.
need to remove only if added?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1081
What it does
How to test
Author checklist