Complete inline tags with blank (fixes #139) #143
+93
−81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bananeweizen
force-pushed
the
javadoc_inline_tag_completion
branch
from
d30420e
to
1603071
Compare
Complete those inline tags with an additional blank character as
completion suffix which take additional text from the user, e.g.
"{@code }" instead of "{@code}".
This reverts half of
https://bugs.eclipse.org/bugs/show_bug.cgi?id=121026, which meant to
only suppress superfluous blanks when adding the completion around
existing text, but wrongly removed blanks also from completion that does
not wrap around input.
jukzi
force-pushed
the
javadoc_inline_tag_completion
branch
from
1603071
to
a634c2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Complete those inline tags with an additional blank character as
completion suffix which take additional text from the user, e.g.
{@code }instead of{@code}.This reverts half of
https://bugs.eclipse.org/bugs/show_bug.cgi?id=121026, which meant to
only suppress superfluous blanks when adding the completion around
existing text, but wrongly removed blanks also from completion that does
not wrap around input. The test case of that linked bug still works as expected after this change.
Be aware that this change has a visual side effect during completion. The suggested completions in the drop down also contain the newly added blank. I would create another change in jdt.ui to remove the blank from the label provider in the drop down to make this look like before.
As you can see from the screenshot, not all tags get an additional blank, but only a known list of tags. Therefore docRoot remains as before.
The result after completion looks like this:
How to test
Author checklist