Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch compiler is inconsistent about separators for package names #1459

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stephan-herrmann
Copy link
Contributor

addresses issue #1458:

This just illustrates a medium, incomplete cleanup towards more consistency.

@stephan-herrmann
Copy link
Contributor Author

I tried to identify a few "sinks" that seem to "need" File.separatorChar:

  • use of java.io.File etc.
  • creation of ClassFileReader
  • access to certain cache fields, like ClasspathDirectory#packageSecondaryTypes and #directoryCache
  • also field ClasspathLocation#path seems to be intended for use with File.separatorChar

In all other cases unconditionally using / looks more straight forward, as it conforms to

  • binary names in byte code
  • paths inside archives incl. jrt

@stephan-herrmann
Copy link
Contributor Author

I'll let it rest until I hear from others, in particular on the (non-)necessity of using File.separatorChar at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant