Add cmd.-line opt. to take optional warn. prop. file #176
+29
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the Eclipse Java Language Server analyze a multi-module Maven project, the lack of a .settings/org.eclipse.jdt.core.prefs file in some of the modules is silently ignored, as if this file existed but simply had no contents. Attempting to recreate this effect when compiling the same project with the Eclipse Java batch compiler, for instance by using the org.codehaus.plexus:plexus-compiler-eclipse add-on to the maven-compiler-plugin, and passing -properties as compilerArgs, is not possible, because the compiler will emit an error on those projects which do not have a warnings property file. This patch introduce an -optprops command-line option, which has the same semantics as the -properties option, except that missing files are silently ignored. By specifying this in the root POM, the entire project may be compiled with the Eclipse Java compiler without having to commit an empty warnings properties file in each of the sub-modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Eclipse Java Language Server analyze a multi-module Maven
project, the lack of a .settings/org.eclipse.jdt.core.prefs file in
some of the modules is silently ignored, as if this file existed but
simply had no contents.
Attempting to recreate this effect when compiling the same project
with the Eclipse Java batch compiler, for instance by using the
org.codehaus.plexus:plexus-compiler-eclipse add-on to the
maven-compiler-plugin, and passing -properties as compilerArgs, is not
possible, because the compiler will emit an error on those projects
which do not have a warnings property file.
This patch introduce an -optprops command-line option, which has the
same semantics as the -properties option, except that missing files
are silently ignored. By specifying this in the root POM, the entire
project may be compiled with the Eclipse Java compiler without having
to commit an empty warnings properties file in each of the
sub-modules.