ASTRewrite support for JEP 430 #1931
Draft
+536
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WIP. Do not merge |
subyssurendran666
force-pushed
the
ASTRewrite-support-String-Templates-1800
branch
from
82ab428
to
3819e0f
Compare
subyssurendran666
force-pushed
the
ASTRewrite-support-String-Templates-1800
branch
from
2c09616
to
8fcc9f9
Compare
mpalat
reviewed
Feb 12, 2024
There was a problem hiding this comment.
@subyssurendran666 Let there be test scenarios for all the properties and atleast a test for each of the operations. An Early comment
mpalat
reviewed
Feb 12, 2024
....model/src/org/eclipse/jdt/core/tests/rewrite/describing/ASTRewritingStringTemplateTest.java
Outdated
Show resolved
Hide resolved
mpalat
reviewed
Feb 12, 2024
|
|
||
| @SuppressWarnings({ "rawtypes", "deprecation" }) | ||
| //SINGLE LINE to MULTI LINE with Multiple Components | ||
| public void test006_c() throws Exception { |
There was a problem hiding this comment.
@subyssurendran666 can you please another test with STRing template processor modified with a name having different length than the original template processor
|
@subyssurendran666 could you please make this patch wrt BETA_JAVA22 |
Sure Manoj |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
#1800
How to test
Author checklist