Capture all information of a source file into one SourceInfo record #1944
+89
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laeubi
force-pushed
the
sort_by_name_with_source_info
branch
2 times, most recently
from
7e45b2c
to
4399315
Compare
laeubi
commented
Feb 1, 2024
org.eclipse.jdt.core.compiler.batch/src/org/eclipse/jdt/internal/compiler/batch/Main.java
Show resolved
Hide resolved
To get a consistent compilation order that is independent of the order of arguments one needs to sort the files to process by name. As the name might be related to to other information all of these are first captured inside a SourceInfo record and are the sort this array by name, in the following code always this sorted array is used and possibly updated with additional information.
laeubi
force-pushed
the
sort_by_name_with_source_info
branch
from
4399315
to
e620924
Compare
|
@iloveeclipse can you review/merge? All checks are green now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
To get a consistent compilation order that is independent of the order of arguments one needs to sort the files to process by name. As the name might be related to to other information all of these are first captured inside a SourceInfo record and are the sort this array by name, in the following code always this sorted array is used and possibly updated with additional information.
How to test
Relates to:
Author checklist