-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pr-validation job and tycho scm parameters #2
Update pr-validation job and tycho scm parameters #2
Conversation
@sravanlakkimsetti : last gerrit failed wit OOM. Any idea what was default on Jenkins and what is default right now? Should we explicitly specify max heap? |
As far as I remember default was 2GB. That should be sufficient. I am unsetting JAVA_TOOL_OPTIONS and _JAVA_OPTIONS. These parameters are set by default in our okd cluster. We had issues with the defaults passed to these in the past. specifically with heap settings. In our gerrit job we were unsetting these params. lets see next build. |
OOM again. Total was 1 GB if I read it right. |
Added 4G heap now. Lets see |
@sravanlakkimsetti : I see my jenkins build started by gerrit is also failing with OOM and other obscure error: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/185619
May be we have issue with last platform build? |
You may be right here. I gave explicit 4GB heap still having this problem. I cannot go more than this as the container has only 4GB of space. Lets try after next platform build. Any other suggestion are welcome. |
Or is the jenkins instance itself has issues? https://ci.eclipse.org/jdt/job/eclipse.jdt.core-Github/job/PR-2/11/console
|
I don't have permissions to restart. Opened Restart JDT JIPP with foundation. |
Tests fail also independently from this PR on master. That must be something with Jenkins. I would unset timeout back to 1 hour, typically JDT tests are done in 30 minutes. Eaiting longer just wastes our time and Jenkins resources. |
I would be surprised if these tests need more than 2GB. They shouldn't. |
Verifying the size on mount points. Need to check the size of tmp
I am wondering this could be problem with /tmp path. I see that most of these tests create project in /tmp path. Is there a way to force creation of test projects at some other place? |
If so, it's Jenkins problem, not our issue. If /tmp is broken, lot of things will go wrong not only in tests. |
using older tycho version
Trying with Tycho 2.7.0 now |
Removed explicit tycho version
using tycho-version 2.7.0 for jdt validation
Just for the record: created tycho ticket eclipse-tycho/tycho#879 |
|
||
unset JAVA_TOOL_OPTIONS | ||
unset _JAVA_OPTIONS | ||
MAVEN_OPTS="-Xmx4G" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wasn't / shouldn't that be 2G ?
- log memory total/used/free on starting every suite - increased max heap for model tests to 2GB - print system properties / environment once for started JVM See eclipse-jdt#2 troubles and eclipse-tycho/tycho#879
- log memory total/used/free on starting every suite - increased max heap for model tests to 2GB - print system properties / environment once for started JVM See eclipse-jdt#2 troubles and eclipse-tycho/tycho#879
- log memory total/used/free on starting every suite - increased max heap for model tests to 2GB - print system properties / environment once for started JVM See eclipse-jdt#2 troubles and eclipse-tycho/tycho#879
- log memory total/used/free on starting every suite - increased max heap for model tests to 2GB - print system properties / environment once for started JVM See eclipse-jdt#2 troubles and eclipse-tycho/tycho#879
For the record, if one properly sets max heap to 2 GB for tycho, OOM errors disappear (should be investigated in eclipse-tycho/tycho#879) but then new test fail appear: #12. |
- log memory total/used/free on starting every suite - increased max heap for model tests to 2GB - print system properties / environment once for started JVM See eclipse-jdt#2 troubles and eclipse-tycho/tycho#879
- log memory total/used/free on starting every model test suite - set explicit max heap for model tests to 1 GB (to identify memory leaks, they need max 0.5 GB) - print system properties / environment once for started JVM See eclipse-jdt#2 troubles and eclipse-tycho/tycho#879
- log memory total/used/free on starting every model test suite - set explicit max heap for model tests to 1 GB (to identify memory leaks, they need max 0.5 GB) - print system properties / environment once for started JVM See #2 troubles and eclipse-tycho/tycho#879
* Create Jenkinsfile * Update Jenkinsfile
Fixes #1