Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insufficient triggers for classpath validation #203

Merged
merged 2 commits into from Jul 14, 2022

Conversation

stephan-herrmann
Copy link
Contributor

fixes #202

one-line fix, I still need to provide tests for it.

@stephan-herrmann stephan-herrmann marked this pull request as ready for review July 12, 2022 13:11
@stephan-herrmann
Copy link
Contributor Author

It turned out that JavaProject already listens to preference changes adding a classpath validation as needed. I just had to enable this for one more option: --release.

Unfortunately, builds are not feeling well today, o.e.j.core.tests.compiler doesn't find jdt.annotations 2.x which was successfully built in the same reactor....

@iloveeclipse
Copy link
Member

@stephan-herrmann : could you please fix new test failure in I20220714-1800 ?

https://download.eclipse.org/eclipse/downloads/drops4/I20220714-1800/testresults/html/org.eclipse.jdt.core.tests.model_ep425I-unit-cen64-gtk3-java11_linux.gtk.x86_64_11.html

xpected markers. ----------- Expected ------------ Exporting a package from system module 'java.desktop' is not allowed with --release.\n The project cannot be built until build path errors are resolved ------------ but was ------------ The project cannot be built until build path errors are resolved\n Exporting a package from system module 'java.desktop' is not allowed with --release. --------- Difference is ---------- expected:<[Exporting a package from system module 'java.desktop' is not allowed with --release.\n The project cannot be built until build path errors are resolved]> but was:<[The project cannot be built until build path errors are resolved\n Exporting a package from system module 'java.desktop' is not allowed with --release.]>

junit.framework.ComparisonFailure: Unexpected markers.
----------- Expected ------------
Exporting a package from system module 'java.desktop' is not allowed with --release.\n
The project cannot be built until build path errors are resolved
------------ but was ------------
The project cannot be built until build path errors are resolved\n
Exporting a package from system module 'java.desktop' is not allowed with --release.
--------- Difference is ----------
expected:<[Exporting a package from system module 'java.desktop' is not allowed with --release.\n
The project cannot be built until build path errors are resolved]> but was:<[The project cannot be built until build path errors are resolved\n
Exporting a package from system module 'java.desktop' is not allowed with --release.]>
at org.eclipse.jdt.core.tests.junit.extension.TestCase.assertStringEquals(TestCase.java:266)
at org.eclipse.jdt.core.tests.junit.extension.TestCase.assertEquals(TestCase.java:242)
at org.eclipse.jdt.core.tests.model.AbstractJavaModelTests.assertMarkers(AbstractJavaModelTests.java:1064)
at org.eclipse.jdt.core.tests.model.ModuleBuilderTests.testAddExportsIllegal(ModuleBuilderTests.java:4810)

iloveeclipse added a commit to iloveeclipse/eclipse.jdt.core that referenced this pull request Jul 15, 2022
@iloveeclipse
Copy link
Member

could you please fix new test failure in I20220714-1800 ?

See #230

iloveeclipse added a commit that referenced this pull request Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insufficient triggers for classpath validation
2 participants