Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a validation step that check if a possible baseline problem is found #2194

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

laeubi
Copy link
Contributor

@laeubi laeubi commented Mar 21, 2024

Fix #1917

This one builds the aggregator with the current PR compiler version and generates a artifact comparator zip if any differences are found:

grafik

@srikanth-sankaran
Copy link
Contributor

Thanks a lot. Will use it next round and share feedback!

@laeubi
Copy link
Contributor Author

laeubi commented Mar 21, 2024

It first needs to be merged though :-)

@srikanth-sankaran
Copy link
Contributor

It first needs to be merged though :-)

And I am hoping next round will not be for several weeks :)

@srikanth-sankaran
Copy link
Contributor

That failure is a known one: #2187

@iloveeclipse
Copy link
Member

and generates a artifact comparator zip if any differences are found:

  1. Currently it produces 900 MB file, while the SDK build produced 450 MB. Something saved twice?
  2. The check succeeds, but shouldn't it fail right now: Verify Eclipse Platform Aggregator Build / build (pull_request) Successful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add aggregator build as github validation step
3 participants