Disambiguate StringTemplate #2214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The parser appears to have the same problem:
adding the import fixes the problem too:
|
|
Thanks @merks ! This actually didn't break the build as maven-javadoc-plugin skips internal packages but it would definitely bite us whenever the jump to Java 21 is done so I have ammended this PR to include it. |
Fixes maven javadoc error "both class org.eclipse.jdt.internal.compiler.ast.StringTemplate in org.eclipse.jdt.internal.compiler.ast and interface java.lang.StringTemplate in java.lang match" as can be seen at https://ci.eclipse.org/platform/job/eclipse.platform.releng.aggregator/job/master/2149/console
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes maven javadoc error "both class
org.eclipse.jdt.internal.compiler.ast.StringTemplate in org.eclipse.jdt.internal.compiler.ast and interface java.lang.StringTemplate in java.lang match" as can be seen at https://ci.eclipse.org/platform/job/eclipse.platform.releng.aggregator/job/master/2149/console
How to test
mvn clean verify javadoc:javadocusing Java 21 as JVM to run Maven completes without error as pointed above.Author checklist