Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JavaDoc for binary classes on modern Java #2369

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

iloveeclipse
Copy link
Member

@iloveeclipse iloveeclipse commented Apr 19, 2024

  • Added example javadoc project with consumer project for manual tests on Java 21
  • with automated tests for Java 21 generated javadoc
  • Java 11 seem to be a mix of old and new styles, so it remains with old code

Fixes #2368

- Added example javadoc project with consumer project for tests
with Java 21 generated javadoc
- no automated tests yet
- Java 11 seem to be a mix of old and new styles, so it remains with old
code
- Java 8 could need same fix like in
JavadocContents17.createSignatureAnchor() for methods with multiple
arguments, but that would break support for older javadoc for now and
introduction of extra JavadocContents8 class

Fixes eclipse-jdt#2368
@iloveeclipse iloveeclipse marked this pull request as ready for review April 22, 2024 09:28
@iloveeclipse iloveeclipse changed the title [WIP] Fix JavaDoc for binary classes on modern Java Fix JavaDoc for binary classes on modern Java Apr 22, 2024
This avoids two new warnings shown by quality gate checks

See eclipse-jdt#2368
@iloveeclipse iloveeclipse merged commit a9b7222 into eclipse-jdt:master Apr 22, 2024
9 checks passed
@iloveeclipse iloveeclipse deleted the issue_1262 branch April 22, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JavaDoc for binary classes does only work partially
1 participant