Clean up compiler implementation of switch expressions #2442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srikanth-sankaran
force-pushed
the
switch-expression-cleanup
branch
3 times, most recently
from
53809f6
to
9e2578a
Compare
3 tasks
srikanth-sankaran
force-pushed
the
switch-expression-cleanup
branch
from
9e2578a
to
33d99e8
Compare
Closed
3 tasks
srikanth-sankaran
force-pushed
the
switch-expression-cleanup
branch
2 times, most recently
from
3f86d13
to
4b3cf08
Compare
srikanth-sankaran
force-pushed
the
switch-expression-cleanup
branch
5 times, most recently
from
c7cea11
to
e0632d0
Compare
srikanth-sankaran
force-pushed
the
switch-expression-cleanup
branch
from
7d16615
to
54dc053
Compare
exception handling switch anymore since we simulate operand stack at all times
covering switch selector type * Fixes eclipse-jdt#2508
srikanth-sankaran
force-pushed
the
switch-expression-cleanup
branch
from
57af8a1
to
99cd906
Compare
This was referenced Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
We don't need to track if a method declaration or a lambda contains an exception handling switch anymore since we simulate operand stack at all times
Fixes Enhance operand stack inconsistency/anomaly checks #2450
Fixes [Switch expressions] java.lang.VerifyError: Bad type on operand stack #2476
Fixes Should tableswitch and lookupswitch set org.eclipse.jdt.internal.compiler.codegen.CodeStream.lastAbruptCompletion ?? #2492
Fixes [Switch expression] Compiler erroneously treats guarded case patterns as covering switch selector type #2508
Fixes [Enhanced switch] Compiler fails to complain about non-exhaustive switch #1777
Author checklist