Remove AbstractUnnamedTypeDeclaration

[datho7561]

What it does

See #2481

• Rework hierarchy so that ImplicitTypeDeclaration depends on AbstractTypeDeclaration
  • Use an empty SimpleName node for ImplicitTypeDeclaration as suggested by Stephen
  • Implement internalResolveBinding() for ImplicitTypeDeclaration
• Revert AbstractTypeDeclaration to how it was before ImplicitTypeDeclaration was added
• Reincorporate Jörg's fix that makes typeName volatile
• Delete AbstractUnnamedTypeDeclaration

How to test

See #2481, it should fix pasting snippets into the package explorer (it doesn't yet, it needs work, currently it throws an "Invalid identifier" exception).

Author checklist

• I have thoroughly tested my changes
• The change is following the coding conventions
• I have signed the Eclipse Contributor Agreement (ECA)

[iloveeclipse]

@jarthana , @stephan-herrmann : tomorrow is RC1 build. It would be very helpful to review (and merge?) this PR ASAP to avoid last minute fixes in RC2.

[srikanth-sankaran]

@jarthana , @stephan-herrmann : tomorrow is RC1 build. It would be very helpful to review (and merge?) this PR ASAP to avoid last minute fixes in RC2.

I am told @jarthana is on leave till Monday. I will study this and share my comments. @mpalat has also offered to look into this - Thanks!

[stephan-herrmann]

Basically looks good, the issue of calling preLazyInit(), postLazyInit() has priority among my remarks.

Let's wait for at least one more review.

[stephan-herrmann]

See #2481, it should fix pasting snippets into the package explorer (it doesn't yet, it needs work, currently it throws an "Invalid identifier" exception).

That requires some reverts in JDT/UI, right? Should those be prepared already?

[iloveeclipse]

That requires some reverts in JDT/UI, right? Should those be prepared already?

Not reverts but careful changes, as some logic changed too => eclipse-jdt/eclipse.jdt.ui#1420

[datho7561]

Sorry I should have prepared a PR with the required changes to jdt.ui, my bad I'll have that up soon too

[iloveeclipse]

Sorry I should have prepared a PR with the required changes to jdt.ui, my bad I'll have that up soon too

No problem, but you can review eclipse-jdt/eclipse.jdt.ui#1420

[datho7561]

Looking into test failures

[datho7561]

They are legitimate, working on a fix

[datho7561]

I can't reproduce the failure (JavaSearchBugsTests2.testBug483650_0002) locally from within Eclipse. I'm going to squash to one commit and clean up the commit message.

[stephan-herrmann]

If build succeeds, this is good to go from my p.o.v.
thanks

[iloveeclipse]

I'm going to sleep now.

If you are going to merge this, please also merge eclipse-jdt/eclipse.jdt.ui#1420 at same time, even if it doesn't compile yet on jenkins, it compiles with this PR. Merging only this PR will break the SDK build.

[mpalat]

If build succeeds, this is good to go from my p.o.v. thanks

@stephan-herrmann @datho7561 Since this is still a preview feature, an "@noreference" to the ImplicitTypeDeclaration is the norm we follow - until it becomes a standard feature. So I would request to add that in the JavaDoc before merging

[iloveeclipse]

@mpalat : I think David can add annotation for the next build. I would like to have all ready for RC1 now, so we can run all tests etc.

[mpalat]

@mpalat : I think David can add annotation for the next build. I would like to have all ready for RC1 now, so we can run all tests etc.

@iloveeclipse - yes, that's sounds fine.