Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[null][external] Option to refer to a dependency in a container for external annotations (#23) #28

Conversation

stephan-herrmann
Copy link
Contributor

  • includes new API for JDT/UI to facilitate supporting this new option
  • streamlined tests to focus on configuration, not content

external annotations (eclipse-jdt#23)

- includes new API for JDT/UI to facilitate supporting this new option
- streamlined tests to focus on configuration, not content
@stephan-herrmann stephan-herrmann force-pushed the Option_to_refer_to_a_dependency_in_a_container_for_external_annotations_#23 branch from dfbb84e to 43c3e50 Compare April 26, 2022 13:11
@iloveeclipse
Copy link
Member

I'm currently trying to help Jay and Stephan to understand why their PR's are hanging...
See #38

While doing that, I've found #45 and that all opened PR's seem to be automatically rebuilt by Jenkins on every change in master branch.

I believe, the PR's should be rebased in github on latest master (that has #45 merged) to avoid that crazy behavior.

It would be nice if @stephan-herrmann would do that now to verify my assumption, save our (jenkins) resources and may be prevent hangs for other PR's.

…y_in_a_container_for_external_annotations_#23
@iloveeclipse
Copy link
Member

I believe all the trouble here could be caused by unfortunate jenkins setup or really by the actual code changes.
I haven't seen any hangs on my PR's I've created today, and I believe parallel job execution should be fixed now.

I've also tried #46 which enables JobManager.VERBOSE mode for tests, all tests were all green there plus one get an idea what the indexer does (but beware: the console output is about 60 MB).

I do not plan to merge that, because the console will explode - but feel free to do try that change too, in case hanging isn't solved after rebase on master here.

@stephan-herrmann
Copy link
Contributor Author

abandoning in favor of #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants