Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 562551 - content assist not working inside lambda expression #30

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jarthana
Copy link
Member

No description provided.

Copy link
Contributor

@gayanper gayanper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, But i would like @stephan-herrmann review as well to see if i missed something. I will also take this PR for a test drive.

@iloveeclipse
Copy link
Member

I'm currently trying to help Jay and Stephan to understand why their PR's are hanging...
See #38

While doing that, I've found #45 and that all opened PR's seem to be automatically rebuilt by Jenkins on every change in master branch.

I believe, the PR's should be rebased in github on latest master (that has #45 merged) to avoid that crazy behavior.

It would be nice if @jarthana would do that now to verify my assumption, save our (jenkins) resources and may be prevent hangs for other PR's.

@stephan-herrmann
Copy link
Contributor

This PR doesn't seem to reflect latest discussion in the original https://bugs.eclipse.org/562551 - @jarthana is your review request still relevant?

@jarthana
Copy link
Member Author

jarthana commented Feb 7, 2023

This PR doesn't seem to reflect latest discussion in the original https://bugs.eclipse.org/562551 - @jarthana is your review request still relevant?

No, it's not. I will revisit this later, whenever I can find some time.

@stephan-herrmann stephan-herrmann removed their request for review May 5, 2024 14:24
@stephan-herrmann
Copy link
Contributor

No, it's not. I will revisit this later, whenever I can find some time.

@jarthana feel free to re-request review when there's more here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants