fix(Scope): set closestMatch when member type not found

[fishautumn]

What it does

fix #465. set closestMatch when member type not found

How to test

I cannot manage to compile the project. As it's pretty simple, just waiting for automatic workflows.

Author checklist

• I have thoroughly tested my changes
• The change is following the coding conventions
• I have signed the Eclipse Contributor Agreement (ECA)

[fishautumn]

with eclipse-platform/eclipse.platform.releng.aggregator I managed to compile it.

but cannot execute the test cases.

[fishautumn]

Bellow CI error seems environment issue:

https://ci.eclipse.org/jdt/job/eclipse.jdt.core-Github/job/PR-466/3/console
13:59:38 [ERROR] Unresolveable build extension: Plugin org.eclipse.tycho:tycho-maven-plugin:3.1.0-SNAPSHOT or one of its dependencies could not be resolved: Failed to read artifact descriptor for org.eclipse.tycho:tycho-maven-plugin:jar:3.1.0-SNAPSHOT @

[iloveeclipse]

If you are still interested on a fix, could you please rebase your PR on master state? Note, the compiler code moved to a dedicated project.

[iloveeclipse]

@fishautumn : two issues:

1. the ECA check failed. Please make sure the mail used to create commits is same you used in ECA.
2. There is a new test fail: CompletionWithMissingTypesTests

junit.framework.ComparisonFailure: 

----------- Expected ------------

------------ but was ------------
MissingType[ANONYMOUS_CLASS_DECLARATION]{, Lmissing.MissingType;, ()V, null, null, [73, 73], 40}\n
   MissingType[TYPE_REF]{missing.MissingType, missing, Lmissing.MissingType;, null, null, [61, 72], 40}\n
MissingType[METHOD_REF<CONSTRUCTOR>]{, Lmissing.MissingType;, ()V, MissingType, null, [73, 73], 40}\n
   MissingType[TYPE_REF]{missing.MissingType, missing, Lmissing.MissingType;, null, null, [61, 72], 40}
--------- Difference is ----------
 expected:<[]> but was:<[MissingType[ANONYMOUS_CLASS_DECLARATION]{, Lmissing.MissingType;, ()V, null, null, [73, 73], 40}\n
   MissingType[TYPE_REF]{missing.MissingType, missing, Lmissing.MissingType;, null, null, [61, 72], 40}\n
MissingType[METHOD_REF<CONSTRUCTOR>]{, Lmissing.MissingType;, ()V, MissingType, null, [73, 73], 40}\n
   MissingType[TYPE_REF]{missing.MissingType, missing, Lmissing.MissingType;, null, null, [61, 72], 40}]>
	at org.eclipse.jdt.core.tests.junit.extension.TestCase.assertStringEquals(TestCase.java:266)
	at org.eclipse.jdt.core.tests.junit.extension.TestCase.assertEquals(TestCase.java:242)
	at org.eclipse.jdt.core.tests.junit.extension.TestCase.assertEquals(TestCase.java:239)
	at org.eclipse.jdt.core.tests.model.AbstractJavaModelCompletionTests.assertResults(AbstractJavaModelCompletionTests.java:213)
	at org.eclipse.jdt.core.tests.model.CompletionWithMissingTypesTests.test0043(CompletionWithMissingTypesTests.java:1772)

[fishautumn]

thanks @iloveeclipse for pointing out the issues. I've update the commits for correct email.

about the test case, I think it makes sense to give completions for given code. so I simply updated it.

[iloveeclipse]

The test still fails: https://ci.eclipse.org/jdt/job/eclipse.jdt.core-Github/job/PR-466/8/testReport/org.eclipse.jdt.core.tests.model/CompletionWithMissingTypesTests/test0043/

[fishautumn]

fixed string constant in test.

[iloveeclipse]

I see some tests modified but I don't understand the problem we are trying to fix here.
How does it show up for the end user? Could a dedicated test be added to show the problem we are trying to fix?

[fishautumn]

LambdaExpressionsTest.test045: changed code causing 1 more error message reported. It can be avoided if necessary.
CompletionWithMissingTypesTests.test0043: I cannot figure out why it affected, because I cannot run the case in local environment.

I will try to add a case for the issue in future.