Guard the new CompletionOnRecordComponentName.#757 #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add proper guard condition for CompletionOnRecordComponentName so that it is created only if the cursor location is in-between the record declaration start and name end position.
gayanper
requested review from
iloveeclipse,
jarthana,
rgrunber and
stephan-herrmann
rgrunber
approved these changes
Feb 17, 2023
|
@iloveeclipse will you handle the merge ? or can i just merge it ? |
Sure you can. |
Seems like the release check is not allowing to merge. How to get around it ? |
Got it merge from desktop browser |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Add proper guard condition for CompletionOnRecordComponentName so that it is created only if the cursor location is in-between the record declaration start and name end position.
How to test
Use test cases in #757
Author checklist