Skip to content

Commit

Permalink
JDIType.throwDebugException() doesn't properly handle disconnected
Browse files Browse the repository at this point in the history
exception (#192)

TL;DR: simply don't override the super method - it does already the
"right thing".

See longer explanation in #192.

Fixes #192
  • Loading branch information
iloveeclipse committed Mar 8, 2023
1 parent 3877dee commit a7078f8
Showing 1 changed file with 0 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,9 @@

import java.text.MessageFormat;

import org.eclipse.core.runtime.IStatus;
import org.eclipse.core.runtime.Status;
import org.eclipse.debug.core.DebugException;
import org.eclipse.jdi.TimeoutException;
import org.eclipse.jdt.debug.core.IJavaType;
import org.eclipse.jdt.debug.core.JDIDebugModel;

import com.sun.jdi.ArrayType;
import com.sun.jdi.ClassType;
Expand Down Expand Up @@ -69,17 +66,6 @@ public void requestFailed(String message, Throwable e, int code)
throwDebugException(message, code, e);
}

/**
* Throws a debug exception with the given message, error code, and
* underlying exception.
*/
@Override
protected void throwDebugException(String message, int code,
Throwable exception) throws DebugException {
throw new DebugException(new Status(IStatus.ERROR,
JDIDebugModel.getPluginIdentifier(), code, message, exception));
}

/**
* Throws a new debug exception with a status code of
* <code>TARGET_REQUEST_FAILED</code> with the given underlying exception.
Expand Down

0 comments on commit a7078f8

Please sign in to comment.