Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SourceLocationTests fail since BETA_JAVA20 merge #212

Closed
iloveeclipse opened this issue Mar 24, 2023 · 2 comments · Fixed by #214
Closed

SourceLocationTests fail since BETA_JAVA20 merge #212

iloveeclipse opened this issue Mar 24, 2023 · 2 comments · Fixed by #214
Assignees
@iloveeclipse
Labels
bug Something isn't working regression Regression from previous release
Milestone
4.28 M1

Comments

@iloveeclipse
Copy link
Member

See https://download.eclipse.org/eclipse/downloads/drops4/I20230323-1800/testresults/html/org.eclipse.jdt.debug.tests_ep428I-unit-cen64-gtk3-java17_linux.gtk.x86_64_17.html

  • testNegativeSystemLibrarySourceLocation
  • testPositiveSystemLibrarySourceLocation

fail with similar stack traces:

Could not find JRE_CONTAINER entry

junit.framework.AssertionFailedError: Could not find JRE_CONTAINER entry
at junit.framework.Assert.fail(Assert.java:57)
at junit.framework.Assert.assertTrue(Assert.java:22)
at junit.framework.Assert.assertNotNull(Assert.java:256)
at junit.framework.TestCase.assertNotNull(TestCase.java:399)
at org.eclipse.jdt.debug.tests.sourcelookup.SourceLocationTests.testNegativeSystemLibrarySourceLocation(SourceLocationTests.java:215)
@iloveeclipse iloveeclipse added bug Something isn't working regression Regression from previous release labels Mar 24, 2023
@iloveeclipse iloveeclipse added this to the 4.28 M1 milestone Mar 24, 2023
@iloveeclipse iloveeclipse mentioned this issue Mar 24, 2023
Closed
@iloveeclipse
Copy link
Member Author

See also #213, probably related?

@iloveeclipse
Copy link
Member Author

See also #213, probably related?

Nope, this must be a regression from ab84816, the fix is trivial, I will push it in a moment.

@iloveeclipse iloveeclipse self-assigned this Mar 24, 2023
iloveeclipse added a commit to iloveeclipse/eclipse.jdt.debug that referenced this issue Mar 24, 2023
@iloveeclipse
Adopt SourceLocationTests to find JRE_CONTAINER
dce86e5 
This was a regression from ab84816.

Fixes eclipse-jdt#212
@iloveeclipse iloveeclipse mentioned this issue Mar 24, 2023
Merged
iloveeclipse added a commit that referenced this issue Mar 24, 2023
@iloveeclipse
Adopt SourceLocationTests to find JRE_CONTAINER
bea8b13 
This was a regression from ab84816.

Fixes #212
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iloveeclipse iloveeclipse

Labels
bug Something isn't working regression Regression from previous release
Projects
None yet
Milestone
4.28 M1
Development

Successfully merging a pull request may close this issue.

Adopt SourceLocationTests to find JRE_CONTAINER iloveeclipse/eclipse.jdt.debug
1 participant
@iloveeclipse