Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMDisconnectedException in EventDispatcher.enableGCForExceptionEvent() #222

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

trancexpress
Copy link
Contributor

Ignore a thrown VMDisconnectedException in
EventDispatcher.dispatch(EventSet) when enabling GC for exception events

Fixes: #221

What it does

How to test

Author checklist

Ignore a thrown VMDisconnectedException in
EventDispatcher.enableGCForExceptionEvent() when enabling GC for
exception events, unless the debug target is not disconnected.

Fixes: eclipse-jdt#221
Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
Copy link
Member

@iloveeclipse iloveeclipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iloveeclipse iloveeclipse merged commit d54da16 into eclipse-jdt:master Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VMDisconnectedException in EventDispatcher.enableGCForExceptionEvent()
2 participants