Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade ASM 9.5 #243

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Upgrade ASM 9.5 #243

merged 1 commit into from
Apr 25, 2023

Conversation

subyssurendran666
Copy link
Contributor

@subyssurendran666 subyssurendran666 commented Apr 21, 2023 •
edited
Loading

Upgrade ASM version to 9.5

Contributors guide: https://github.com/eclipse-jdt/.github/blob/main/CONTRIBUTING.md

What it does

How to test

Author checklist

@subyssurendran666 subyssurendran666 marked this pull request as draft April 21, 2023 12:12
@SarikaSinha SarikaSinha self-requested a review April 21, 2023 12:23
@iloveeclipse
Copy link
Member

Haven't done review yet, but
Please

  1. Don't create / push merge commits, rebase on master instead
  2. add Fixes https://github.com/eclipse-jdt/eclipse.jdt.debug/issues/224 line to commit message.

@subyssurendran666 subyssurendran666 marked this pull request as ready for review April 21, 2023 13:02
@subyssurendran666 subyssurendran666 mentioned this pull request Apr 24, 2023
Closed
@iloveeclipse
Copy link
Member

  • I've squashed two commits to one
  • added proper commit message
  • re-built jar just to make sure it works with new pom/manifest

LGTM.

@iloveeclipse iloveeclipse merged commit c540b0a into eclipse-jdt:master Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SarikaSinha SarikaSinha Awaiting requested review from SarikaSinha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@subyssurendran666 @iloveeclipse