Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot run JDT cleanups for multiple projects in project explorer #34

Closed
vogella opened this issue May 5, 2022 · 6 comments · Fixed by #48
Closed

Cannot run JDT cleanups for multiple projects in project explorer #34

vogella opened this issue May 5, 2022 · 6 comments · Fixed by #48
Assignees
Labels
bug Something isn't working
Milestone

Comments

@vogella
Copy link
Contributor

vogella commented May 5, 2022

To run source cleanups for multiple projects I have to use the package explorer. Project explorer does only allow this for a select source folder.

Project explorer:

image

Package Explorer:

image

Would be really nice to be able to use project explorer for this also, as it is the default view for all perspectives except the JDT one and I only use project explorer because it has features package explorer does not have like hierarchiy view and an easy to reach filter button.

@vogella
Copy link
Contributor Author

vogella commented May 5, 2022

@tsmaeder can you have a look?

@vogella
Copy link
Contributor Author

vogella commented May 5, 2022

Originally reported via https://bugs.eclipse.org/bugs/show_bug.cgi?id=548265

@jjohnstn jjohnstn added the bug Something isn't working label May 6, 2022
jjohnstn added a commit to jjohnstn/eclipse.jdt.ui-1 that referenced this issue May 11, 2022
- fixes eclipse-jdt#34
- support IProject selection in CleanUpAction.isEnabled() and
  CleanUpAction.getCompilationUnits()
@jjohnstn jjohnstn self-assigned this May 11, 2022
@jjohnstn
Copy link
Contributor

@vogella Could you take a look at the PR I submitted to see if I have missed something? The fix is simple and I am able to run cleanups/format on projects and multiple projects in the Project Explorer. No tests as of yet.

@vogella
Copy link
Contributor Author

vogella commented May 19, 2022

@jjohnstn the change is already a big enhancement, would be nice if it could also work if some of the projects are also not Java projects but as it is it is already a huge improvement for me. Btw. I also commented on the PR, not sure if you got a notifcation for that.

@jjohnstn
Copy link
Contributor

I'm glad it works for you. I somehow missed your comment on the PR which is too bad (too many github notifications coming in). I'll merge it for 4.25 M1 as 4.24 M3 deadline has already passed. Regarding Java vs non-Java, what behaviour are you expecting? Do you expect CleanUpActions to ignore all non-Java projects so the action only works on applicable Java projects or something else entirely?

@jjohnstn jjohnstn added this to the 4.25 milestone May 19, 2022
@vogella
Copy link
Contributor Author

vogella commented Jun 8, 2022

Could the existing PR already be merged? Would already be a huge improvement.

Do you expect CleanUpActions to ignore all non-Java projects so the action only works on applicable Java projects or something else entirely?

Similar to current behavior of Package Explorer, non-Java project should be ignored / skipped.

jjohnstn added a commit that referenced this issue Jun 8, 2022
- fixes #34
- support IProject selection in CleanUpAction.isEnabled() and
  CleanUpAction.getCompilationUnits()
@jjohnstn jjohnstn modified the milestones: 4.25, 4.25 M1 Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants