-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot run JDT cleanups for multiple projects in project explorer #34
Comments
@tsmaeder can you have a look? |
Originally reported via https://bugs.eclipse.org/bugs/show_bug.cgi?id=548265 |
- fixes eclipse-jdt#34 - support IProject selection in CleanUpAction.isEnabled() and CleanUpAction.getCompilationUnits()
@vogella Could you take a look at the PR I submitted to see if I have missed something? The fix is simple and I am able to run cleanups/format on projects and multiple projects in the Project Explorer. No tests as of yet. |
@jjohnstn the change is already a big enhancement, would be nice if it could also work if some of the projects are also not Java projects but as it is it is already a huge improvement for me. Btw. I also commented on the PR, not sure if you got a notifcation for that. |
I'm glad it works for you. I somehow missed your comment on the PR which is too bad (too many github notifications coming in). I'll merge it for 4.25 M1 as 4.24 M3 deadline has already passed. Regarding Java vs non-Java, what behaviour are you expecting? Do you expect CleanUpActions to ignore all non-Java projects so the action only works on applicable Java projects or something else entirely? |
Could the existing PR already be merged? Would already be a huge improvement.
Similar to current behavior of Package Explorer, non-Java project should be ignored / skipped. |
- fixes #34 - support IProject selection in CleanUpAction.isEnabled() and CleanUpAction.getCompilationUnits()
To run source cleanups for multiple projects I have to use the package explorer. Project explorer does only allow this for a select source folder.
Project explorer:
Package Explorer:
Would be really nice to be able to use project explorer for this also, as it is the default view for all perspectives except the JDT one and I only use project explorer because it has features package explorer does not have like hierarchiy view and an easy to reach filter button.
The text was updated successfully, but these errors were encountered: