Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for code completion inside text block templates #1038 #1055

Merged
merged 1 commit into from Jan 10, 2024

Conversation

ktatavarthi
Copy link
Member

@ktatavarthi ktatavarthi commented Jan 9, 2024

What it does

Adds support for code completion within text blocks
This works in tandem with the JDT Core PR - eclipse-jdt/eclipse.jdt.core#1803.

This change adds the text block related jdt ui partition to the relevant code completion extensions.
Fixes #1038

How to test

  1. Create a Java15 compliant or above project.
  2. Create class C1 and main function in it.
  3. Add the below code in the function
  4. press Ctrl + Space, positioning the cursor in the text block after System.
String abc= STR."""
	\{System.}
	""";

The expected behavior is that the code completion suggestions should pop up at this stage.

Author checklist

…dt#1038

Signed-off-by: Kalyan Prasad Tatavarthi <kalyan_prasad@in.ibm.com>
Copy link
Member

@jarthana jarthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the changes along with the relevant jdt.core changes and things are looking good.

@jarthana jarthana merged commit 82300c2 into eclipse-jdt:master Jan 10, 2024
9 checks passed
Copy link
Member

@noopur2507 noopur2507 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks, Kalyan.

noopur2507 pushed a commit that referenced this pull request Jan 22, 2024
)

Signed-off-by: Kalyan Prasad Tatavarthi <kalyan_prasad@in.ibm.com>
noopur2507 added a commit that referenced this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for code completion inside text block templates
3 participants