Fix jar-in-jar-loader multi-release support
#1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to open a JAR file in multi-release mode the URL of the file must be suffixed with `#runtime`. Currently the `rsrc:` URL handler strips this fragment, which breaks multi-release JARs retrieved through the `rsrc:` protocol.
|
Looks fine. There is FatJarExportTest.java which might be a candidate to add the test to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
In order to open a JAR file in multi-release mode the URL of the file must be suffixed with
#runtime.Currently the
rsrc:URL handler strips this fragment, which breaks multi-release JARs retrieved through thersrc:protocol.This PR copies the
#runtimefragment from thersrc:URL to the URL of the underlying resource.Closes #1057.
How to test
A minimal reproducible example is available at copernik-eu/bug-reproducibility/eclipse-jar-in-jar.
I can provide a JUnit test if you point to the right module, where to put it.
Author checklist