Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Open Call Hierarchy' hyperlink for type elements too. Fixes #1231 #1367

Merged
merged 1 commit into from
May 2, 2024

Conversation

RedeemerSK
Copy link
Contributor

What it does

Adds 'Open Call Hierarchy' item to the list of "hyperlinks" (actions offered on CTRL + mouse hover) for Java types (classes/enums/records) as well.

How to test

CTRL + mouse hover over various elements in opened editor, 'Open Call Hierarchy' should be offered for elements for which call hierarchy can be actually shown.

Author checklist

@iloveeclipse
Copy link
Member

Screenshot? The patch looks nice.

@RedeemerSK
Copy link
Contributor Author

Screenshot? The patch looks nice.

open_call_hierarchy

@iloveeclipse
Copy link
Member

iloveeclipse commented Apr 24, 2024

Could you please change commit message and put an empty new line before the "Fixes ..." part?

@iloveeclipse iloveeclipse merged commit c13bcd3 into eclipse-jdt:master May 2, 2024
9 checks passed
@iloveeclipse iloveeclipse linked an issue May 6, 2024 that may be closed by this pull request
RedeemerSK added a commit to RedeemerSK/www.eclipse.org-eclipse that referenced this pull request May 8, 2024
RedeemerSK added a commit to RedeemerSK/www.eclipse.org-eclipse that referenced this pull request May 8, 2024
iloveeclipse pushed a commit to eclipse-platform/www.eclipse.org-eclipse that referenced this pull request May 8, 2024
@howlger
Copy link
Contributor

howlger commented Jun 2, 2024

In the Eclipse SDK 4.32 RC2, on Ctrl+hover I see Open Call Hierarchy for a record (TestRecord) and for an enum (TestEnum) as expected, but not for a class (TestClass):

public class OpenCallHierarchyTest {

	public class TestClass { }

	public record TestRecord(int x) { }

	public enum TestEnum { VAL }

	public interface TestInterface { }

}

@RedeemerSK
Copy link
Contributor Author

RedeemerSK commented Jun 3, 2024

In the Eclipse SDK 4.32 RC2, on Ctrl+hover I see Open Call Hierarchy for a record (TestRecord) and for an enum (TestEnum) as expected, but not for a class (TestClass):

public class OpenCallHierarchyTest {

	public class TestClass { }

	public record TestRecord(int x) { }

	public enum TestEnum { VAL }

	public interface TestInterface { }

}

Strange ... I just checked with https://download.eclipse.org/eclipse/downloads/drops4/S-4.32RC2a-202406010610/ and it works as expected.

(EDIT: works with only other RC1 build as well :https://download.eclipse.org/eclipse/downloads/drops4/S-4.32RC2-202405291800/ )

@howlger
Copy link
Contributor

howlger commented Jun 3, 2024

...

Strange ... I just checked with https://download.eclipse.org/eclipse/downloads/drops4/S-4.32RC2a-202406010610/ and it works as expected.

(EDIT: works with only other RC1 build as well :https://download.eclipse.org/eclipse/downloads/drops4/S-4.32RC2-202405291800/ )

Thanks for checking. You are right, the menu item Open Call Hierarchy is there, but hidden by the horizontal scrollbar on Windows 11 with a high-DPI display (3840 x 2400; scaling: 250%):

Screenshot 2024-06-03 223934

For the record, the enum and the interface the Ctrl hover menu has only two menu items without scrollbars as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CTRL+Click "Open Call Hierarchy" Action on classes
3 participants