Fix move instance processor to handle class instance creation accessibility #1413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add logic to the MethodBodyRewriter so it will recognize a constructor call that will be inaccessible after moving and try to modify the accessibility of the constructor - fix the ThisReferenceFinder to ignore field references made from a local variable - add new tests to MoveInstanceMethodTests - fixes eclipse-jdt#1304
jjohnstn
force-pushed
the
privateconstructor
branch
from
8c8c51a
to
614df03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
See title.
How to test
See original issue or new tests.
Author checklist