Enable Github Verification and cleanup build scripts #536
Conversation
laeubi
force-pushed
the
unified_build
branch
2 times, most recently
from
36ec0bd
to
382a351
Compare
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit d1e6de9. ♻️ This comment has been updated with latest results. |
|
Some tests seem to show different offsets on |
There was a problem hiding this comment.
OK, it happened what I've expected.
As long as github actions fail and reporting is as bad as it is, I would not merge this.
I personally have hard time to understand the "fail" output, and which build produced which "error" (which is not an error but test fail, but that's known issue).
I don't want / don't have time to explain every contributor on every PR that the various fails that we report are to be ignored (!!!), because later it causes that even experienced committer assume the PR is "safe" just because it fails everywhere else.
See for example eclipse-platform/eclipse.platform.ui#703 (comment)
=>
The way to proceed is to analyze fails and why they differ between maven / jenkins / official builds and to provide patches that would fix test fails or at least mute the known issues on github only.
|
I think I can't help here much as I don't know why absolute pixel positions are asserted in the tests, you can take a look here what are the hardware configurations for the different runner images: |
akurtakov
force-pushed
the
unified_build
branch
from
382a351
to
5fff25e
Compare
This do the follwoing: - enable the unified github verification build - removes obsolete workflows - move mandatory maven options into the maven.config file
This do the follwoing:
FYI @iloveeclipse