Add quick assistance for field rename refactoring

[DongChunHao]

What it does

• modify QuickAssistProcessor.java to add quick assist for renaming constant fields
• Fix: Add quick assistance for field rename refactoring #749

How to test

• Open"New_configuration", select the field that doesn't follow constant naming convention，click on 'ctrl+1'.
  

Author checklist

• I have thoroughly tested my changes
• The change is following the coding conventions
• I have signed the Eclipse Contributor Agreement (ECA)

[DongChunHao]

@jjohnstn We changed the code based on your suggestions, please kindly have a look on the resubmitted PR.

[jjohnstn]

Will look at it, thx.

[jjohnstn]

Hi @DongChunHao thanks for the patch. There a few comments you need to address. Mostly to do with the logic which needs to use bindings instead of name comparison which is unreliable.

[jjohnstn]

This class should be in: org.eclipse.jdt.internal.ui.text.correction.proposals

[DongChunHao]

@jjohnstn
I have made all the changes as per your request. Please kindly have a look on the resubmitted PR，thanks.
I modified the binding logic and naming conventions of the code. Currently, the code supports automatic modification of fields that do not comply with the constant naming convention, including the special cases(A___B) you mentioned with multiple underscores.

[jjohnstn]

Hi @DongChunHao Thanks for the previous changes. A few more changes to finish this. See new comments. You also need to add tests to the AssistQuickFixTest class.

[jjohnstn]

Make the pattern a final static variable in the class so it only needs to be evaluated once.

[jjohnstn]

Need a check that the new name isn't already used. At this point, you can use the FieldDeclaration to find it's AbstractTypeDeclaration parent and then do an ASTVisitor to find FieldDeclarations and mark whether there is already a field with newName. The refactoring is catching it, but you shouldn't offer the assist if this is the case.

[jjohnstn]

Build an NLS string here that says something like Rename 'recLimit' to 'REC_LIMIT' so something shows up in the 2nd window like you see when you click on Create getter and setter for x... You can use positional variables in the NLS string.

e.g. ConvertFieldUsingConstantNaming_additional_info=Rename the field ''{0}'' to ''{1}''

and then use the Messages.format() to add the parameters to the string that you will return.

[DongChunHao]

@jjohnstn
Thank you for your feedback. I have made the changes according to your suggestions. Please review the resubmitted PR, thanks.
The current implementation's runtime result：

[jjohnstn]

/rebase

[jjohnstn]

/rebase

[jjohnstn]

/rebase

[jjohnstn]

@DongChunHao I made some additional fixes. For the future, you cannot hard-code strings that get displayed as they need to be translatable so must be put into properties files. The comment I made about the Pattern was to do the compile as part of a final static variable so the compile only occurs once for the class. Anyway, done.

[DongChunHao]

Hi, @jjohnstn Thank you very much for your assistance, teaching me how to modify the code and pay attention to development standards. I will be more mindful in the future. Thanks again, and all the best.

[iloveeclipse]

This causes regression, see #820