Use JLS23 as latest compliance level in AST

[gayanper]

Currently JavaCore returns the latest supported java version as Java 23, But the AST validation is restricted to Java 22, this cause the issue with vscode java debugger, which sends the compliancy level as 23 when evaluating debug breakpoints to be registered.

[gayanper]

@mickaelistria another small fix to make javac usable with debugging in vscode.

[mickaelistria]

This seems to cause ~60 new test failures: https://ci.eclipse.org/ls/job/jdt-core-incubator/job/PR-465/1/
The issue is that when we set the "latest" then many other bits of JDT expect that ECJ can support this latest too, which is not the case yet.This seems to cause ~60 new test failures: https://ci.eclipse.org/ls/job/jdt-core-incubator/job/PR-465/1/
The issue is that when we set the "latest" then many other bits of JDT expect that ECJ can support this latest too, which is not the case yet. So far, the approach of declaring the new versions but not listing them as "latest" has been the best working one. Do you know where in your use-case is JLS_Latest being used?

[gayanper]

If we check the code here https://github.com/microsoft/java-debug/blob/83403a458e0d01fba5a3871fea81af742460bdf0/com.microsoft.java.debug.plugin/src/main/java/com/microsoft/java/debug/plugin/internal/JdtSourceLookUpProvider.java#L103

as we can see it reads the latest java version from JavaCore.latestSupportedJavaVersion() which has the following implementation in our incubator

	public static String latestSupportedJavaVersion() {
		return allVersions.get(allVersions.size() - 1);
	}

allVersions has VERSION_23 as the last element.

[gayanper]

@mickaelistria How should we handle this ?

[mickaelistria]

I'm curious about "AST validation is restricted to Java 22", can you please elaborate how we can see this? I think AST validation should be working for any known AST version, independently of what's the one marked as latest.

[gayanper]

I'm curious about "AST validation is restricted to Java 22", can you please elaborate how we can see this? I think AST validation should be working for any known AST version, independently of what's the one marked as latest.

The problem happens in https://github.com/gayanper/eclipse.jdt.core/blob/81b72d0d5ee1283ae61f543bb64d6e966fd35e22/org.eclipse.jdt.core/dom/org/eclipse/jdt/core/dom/AST.java#L1181

Since the constant at https://github.com/gayanper/eclipse.jdt.core/blob/81b72d0d5ee1283ae61f543bb64d6e966fd35e22/org.eclipse.jdt.core/dom/org/eclipse/jdt/core/dom/AST.java#L546 is not pointing to the latest version provided by avaCore.latestSupportedJavaVersion() method.