Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix printing abstract or not on interface methods #483

Open
wants to merge 290 commits into
base: dom-with-javac
Choose a base branch
from
Open

Fix printing abstract or not on interface methods #483

wants to merge 290 commits into from

Conversation

mickaelistria
Copy link

No description provided.

mickaelistria and others added 30 commits June 8, 2024 11:56
@mickaelistria
More support for Completion
9ba9320 
+ move DOM-based selection and completion to codeassist package.
@mickaelistria
[Javac] Add some recovery to converter
3f663a1 
process more contents in JCError nodes
@mickaelistria
[DOM] completion improvements
635e6c9 
Fix some positions and others.
@mickaelistria
[DOM][Completion] Improve filtering
025fdfd 
Honor the search pattern settings.
@datho7561 @mickaelistria
Add implementations for JavacMemberValuePairBinding
a20eb38 
Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 @mickaelistria
Implement JavacAnnotationBinding.getKey
64d0c67 
Closes eclipse-jdt#218

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 @mickaelistria
Implement methods in JavacPackageBinding
43cd038 
Closes eclipse-jdt#219

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 @mickaelistria
Fix a compilation error caused by two of my previous commits overlapping
c31c8e1 
Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 @mickaelistria
Implement remaining methods in JavacVariableBinding
883c31b 
Signed-off-by: David Thompson <davthomp@redhat.com>
@testforstephen @mickaelistria
Set the project's sourcepath/classpath/output and compilation version…
40b231a 
… to Javac compiler (eclipse-jdt#268)
@mickaelistria
Missing implements on some types
57c5376 
Signed-off-by: Rob Stryker <stryker@redhat.com>
@mickaelistria
Array Initializer not set
c46c99d 
Signed-off-by: Rob Stryker <stryker@redhat.com>
@mickaelistria
Bug in translating character literals
6fb2182 
Signed-off-by: Rob Stryker <stryker@redhat.com>
@mickaelistria
Array Initializer has incorrect start position
67e4767 
Signed-off-by: Rob Stryker <stryker@redhat.com>
@mickaelistria
int x,y not handled properly in some cases
a5df887 
Signed-off-by: Rob Stryker <stryker@redhat.com>
@mickaelistria
Missing default value in code like int id() default 0;
f10b7ab 
Signed-off-by: Rob Stryker <stryker@redhat.com>
@mickaelistria
int x,y format fields inside anonymous class was incorrect
517bd2e 
Signed-off-by: Rob Stryker <stryker@redhat.com>
@mickaelistria
Annotations are incorrectly ordered ahead of visibility in some cases
d4b683b 
Signed-off-by: Rob Stryker <stryker@redhat.com>
@mickaelistria
Annotations on package declaration
4923d7c 
Signed-off-by: Rob Stryker <stryker@redhat.com>
@mickaelistria
Off by one errors on javadoc
c75fca5 
Signed-off-by: Rob Stryker <stryker@redhat.com>
@datho7561 @mickaelistria
[javac] convert module into tree
c87a115 
Signed-off-by: David Thompson <davthomp@redhat.com>
@mickaelistria
Get source ranges for module directive source ranges
db74795 
Signed-off-by: Rob Stryker <stryker@redhat.com>
@mickaelistria
Add args to methods completion
c5931b8
@datho7561 @mickaelistria
[javac] Binding fixes discovered during implementing resolve
e3343a0 
Signed-off-by: David Thompson <davthomp@redhat.com>
@mickaelistria
Some support to convert H<P>.N types format
08819bb
@mickaelistria
Use fileManager to get fileObject
1761663 
Fixes eclipse-jdtls#275
@mickaelistria
Support building mulitple files with same Javac context
30bd9a1
@mickaelistria
Cleanup
25c0961
@akurtakov @mickaelistria
Fix javac enabling preview
0605404 
Setting value is "enabled" and thus has to be handled like all the other
"enabled" options.
@datho7561 @mickaelistria
Fix regression in JavacCompilationUnitResolver.parse()
94091b3 
Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 and others added 17 commits June 10, 2024 18:40
@datho7561 @mickaelistria
Use reflection to access the Javadoc offset
11f574a 
The offset reported for Javadoc comments for the access method
we are currently using is almost always -1.
By accessing the offset value directly reflexively,
we can access the value we really want,
the offset of the `/**` token,
which is stored in a parent class as a private final field.

Signed-off-by: David Thompson <davthomp@redhat.com>
@gayanper @mickaelistria
Fix type annotation binding resolution
98a88cc 
The type annotation are now read from the typeSymbol
as it has done for method annotations.
@datho7561
Fix bug in getting segments of packagebinding
3968d5d 
Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 @mickaelistria
Prevent IllegalArgumentException when adjusting unclosed string range
86aad2f 
Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 @mickaelistria
Fix getExceptionTypes for JavacMethodBinding
d575c88 
Signed-off-by: David Thompson <davthomp@redhat.com>
@gayanper @mickaelistria
Fix type resolution in method parameter binding
80b2a50 
Use the TypeSymbol when available instead of toString to avoid TypeSignature
creation failures due to toString could provide information in addition to
what is expected by TypeSignature creation.
@datho7561 @mickaelistria
Wrap parse of each compilation unit in try/catch
08e372b 
Rethrow the first throwable encountered

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561
Handle another corner case for QualifiedName
59bb19e 
Even if it's technically a field access, if all the segments are simple
names without any class names, method invocations, or keywords,
then it should be treated as a qualified name for the purpose of
converting to the JDT AST.

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 @mickaelistria
Fix binding bug with qualified names
6c73f3c 
Signed-off-by: David Thompson <davthomp@redhat.com>
@mickaelistria
Resolve parent parameterized type binding when available
8f3255d
@datho7561 @mickaelistria
Handle some ArrayInitializer DOM conversion and bindings
72ca712 
Signed-off-by: David Thompson <davthomp@redhat.com>
@mickaelistria
Fix some new array dimensions
fd31a7d
Add compilation unit resolver extension point and open a minimal set …
119abcd 
…of API to be useful

Signed-off-by: Rob Stryker <stryker@redhat.com>

Cleanup ASTParser for legibility and to use the new interface

Signed-off-by: Rob Stryker <stryker@redhat.com>

Add facade to CompilationUnitResolver

Signed-off-by: Rob Stryker <stryker@redhat.com>

exsd doc change

Signed-off-by: Rob Stryker <stryker@redhat.com>

Partial revert and cleanup

Signed-off-by: Rob Stryker <stryker@redhat.com>

Clean up API changes and proposed interface

Signed-off-by: Rob Stryker <stryker@redhat.com>

Undo api changes

Signed-off-by: Rob Stryker <stryker@redhat.com>
Implement the extension point
d58ca48 
Signed-off-by: Rob Stryker <stryker@redhat.com>

Javadoc for added interface

Signed-off-by: Rob Stryker <stryker@redhat.com>

More docs
@mickaelistria
Fix modifiers for interface method bindings
aa2a689
@mickaelistria
Fix some binding.toString()
7351015
@mickaelistria
Improve dimensions
c8a5767
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mickaelistria mickaelistria

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mickaelistria @datho7561 @testforstephen @akurtakov @snjeza @gayanper @fbricon