Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the type root for some units where it wasn't yet #489

Open
wants to merge 296 commits into
base: dom-with-javac
Choose a base branch
from
Open

Set the type root for some units where it wasn't yet #489

wants to merge 296 commits into from

Conversation

datho7561
Copy link

  • Fixes error when executing cleanups in the Eclipse IDE
  • Cleanups still don't work (they don't do anything)

@mickaelistria
Copy link

This seems to add a bunch of extra failures.

datho7561 and others added 28 commits June 14, 2024 15:50
@datho7561 @mickaelistria
Implement methods in JavacPackageBinding
16562bc 
Closes eclipse-jdt#219

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 @mickaelistria
Fix a compilation error caused by two of my previous commits overlapping
077d38e 
Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 @mickaelistria
Implement remaining methods in JavacVariableBinding
5585213 
Signed-off-by: David Thompson <davthomp@redhat.com>
@testforstephen @mickaelistria
Set the project's sourcepath/classpath/output and compilation version…
7911481 
… to Javac compiler (eclipse-jdt#268)
@mickaelistria
Missing implements on some types
f92ecc5 
Signed-off-by: Rob Stryker <stryker@redhat.com>
@mickaelistria
Array Initializer not set
21399cf 
Signed-off-by: Rob Stryker <stryker@redhat.com>
@mickaelistria
Bug in translating character literals
60c51e5 
Signed-off-by: Rob Stryker <stryker@redhat.com>
@mickaelistria
Array Initializer has incorrect start position
1d71901 
Signed-off-by: Rob Stryker <stryker@redhat.com>
@mickaelistria
int x,y not handled properly in some cases
eb5c6ba 
Signed-off-by: Rob Stryker <stryker@redhat.com>
@mickaelistria
Missing default value in code like int id() default 0;
93776e9 
Signed-off-by: Rob Stryker <stryker@redhat.com>
@mickaelistria
int x,y format fields inside anonymous class was incorrect
befb04c 
Signed-off-by: Rob Stryker <stryker@redhat.com>
@mickaelistria
Annotations are incorrectly ordered ahead of visibility in some cases
9923eff 
Signed-off-by: Rob Stryker <stryker@redhat.com>
@mickaelistria
Annotations on package declaration
b8c3b6a 
Signed-off-by: Rob Stryker <stryker@redhat.com>
@mickaelistria
Off by one errors on javadoc
803d08d 
Signed-off-by: Rob Stryker <stryker@redhat.com>
@datho7561 @mickaelistria
[javac] convert module into tree
3d4317d 
Signed-off-by: David Thompson <davthomp@redhat.com>
@mickaelistria
Get source ranges for module directive source ranges
0f86b08 
Signed-off-by: Rob Stryker <stryker@redhat.com>
@mickaelistria
Add args to methods completion
bc8a05c
@datho7561 @mickaelistria
[javac] Binding fixes discovered during implementing resolve
5f5d9f1 
Signed-off-by: David Thompson <davthomp@redhat.com>
@mickaelistria
Some support to convert H<P>.N types format
7cca442
@mickaelistria
Use fileManager to get fileObject
3c0db29 
Fixes eclipse-jdtls#275
@mickaelistria
Support building mulitple files with same Javac context
e97548e
@mickaelistria
Cleanup
7396da2
@akurtakov @mickaelistria
Fix javac enabling preview
e6f007b 
Setting value is "enabled" and thus has to be handled like all the other
"enabled" options.
@datho7561 @mickaelistria
Fix regression in JavacCompilationUnitResolver.parse()
05aa7f8 
Signed-off-by: David Thompson <davthomp@redhat.com>
@mickaelistria
Make converter more tolerant
f10ef5d 
fail less, log more.
@mickaelistria
Fix NPE when receiving "external" diagnostics
6e8b416 
Fix eclipse-jdtls#285
@datho7561 @mickaelistria
Improve Javac(Method|Type)Binding.getKey() (eclipse-jdt#273)
199884c 
Fixes eclipse-jdt#284

---------

Signed-off-by: David Thompson <davthomp@redhat.com>
Signed-off-by: Rob Stryker <stryker@redhat.com>
Co-authored-by: Rob Stryker <stryker@redhat.com>
@mickaelistria
Basic support for JavacTask
e67a959 
Seems a better API than drilling down in JavacCompiler.
datho7561 and others added 20 commits June 14, 2024 15:51
@datho7561 @mickaelistria
Wrap parse of each compilation unit in try/catch
46fc291 
Rethrow the first throwable encountered

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 @mickaelistria
Handle another corner case for QualifiedName
b7ebf23 
Even if it's technically a field access, if all the segments are simple
names without any class names, method invocations, or keywords,
then it should be treated as a qualified name for the purpose of
converting to the JDT AST.

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 @mickaelistria
Fix binding bug with qualified names
5f8163e 
Signed-off-by: David Thompson <davthomp@redhat.com>
@mickaelistria
Resolve parent parameterized type binding when available
3e36dbf
@datho7561 @mickaelistria
Handle some ArrayInitializer DOM conversion and bindings
9d47427 
Signed-off-by: David Thompson <davthomp@redhat.com>
@mickaelistria
Fix some new array dimensions
bb38664
@mickaelistria
Add compilation unit resolver extension point and open a minimal set …
ff1cf78 
…of API to be useful

Signed-off-by: Rob Stryker <stryker@redhat.com>

Cleanup ASTParser for legibility and to use the new interface

Signed-off-by: Rob Stryker <stryker@redhat.com>

Add facade to CompilationUnitResolver

Signed-off-by: Rob Stryker <stryker@redhat.com>

exsd doc change

Signed-off-by: Rob Stryker <stryker@redhat.com>

Partial revert and cleanup

Signed-off-by: Rob Stryker <stryker@redhat.com>

Clean up API changes and proposed interface

Signed-off-by: Rob Stryker <stryker@redhat.com>

Undo api changes

Signed-off-by: Rob Stryker <stryker@redhat.com>
@mickaelistria
Implement the extension point
f3c3477 
Signed-off-by: Rob Stryker <stryker@redhat.com>

Javadoc for added interface

Signed-off-by: Rob Stryker <stryker@redhat.com>

More docs
@mickaelistria
Fix modifiers for interface method bindings
ccfdcee
@mickaelistria
Fix some binding.toString()
4287901
@mickaelistria
Improve dimensions
d2b3b6f
@mickaelistria
workaround some endPos issue, support any expr in try-resourecs
d475bcc
@mickaelistria
Convert SuperMethodReference
a37645c
@mickaelistria
Fix some VariableBinding.getVariableId()
478a82f 
as per Javadoc on interface, using start position can do the job
@mickaelistria
Resolve type for cast expression
fd9cd76
@mickaelistria
Align incubator ICompilationUnitResolver code with current PR
7d17c4b 
Signed-off-by: Rob Stryker <stryker@redhat.com>
@testforstephen @mickaelistria
Force Javac to proceed the build process despite compilation errors
df9e73e
@datho7561 @mickaelistria
Adjust source range for this constructor invocation
5a5834d 
Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 @mickaelistria
Handle SingleVariableDeclaration with trailing [][][]
208c218 
eg. Adjust the source range to be correct in this case:

`for (final String asdf[][] : myListOfArrayOfArrayOfString) {}`

Signed-off-by: David Thompson <davthomp@redhat.com>
@mickaelistria
Use Type.flatName to compute binding key
4c6a3af
@datho7561 datho7561 force-pushed the dom-with-javac-fix-exception-in-cleanups branch from b4a2b0a to ee035f2 Compare June 14, 2024 15:51
mickaelistria and others added 5 commits June 14, 2024 18:30
@mickaelistria
Fix some impls in JavacTypeBinding
81d58ab
@mickaelistria
Improve how we lookup methods
45169e8 
Fixes eclipse-jdtls#487
@mickaelistria
Fix infix expression representation in dom tree
bf97502 
Signed-off-by: Rob Stryker <stryker@redhat.com>
@datho7561 @mickaelistria
Fix isRecovered for annotation bindings
8f2e1df 
- Small bug fix related to getKey for annotation bindings where the
  parent is sometimes not set correctly

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 @mickaelistria
Set the type root for some units where it wasn't yet
113f4a2 
- Fixes error when executing cleanups in the Eclipse IDE
- Cleanups still don't work (they don't do anything)

Signed-off-by: David Thompson <davthomp@redhat.com>
@mickaelistria mickaelistria force-pushed the dom-with-javac-fix-exception-in-cleanups branch from ee035f2 to 113f4a2 Compare June 15, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@datho7561 datho7561

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@datho7561 @mickaelistria @testforstephen @akurtakov @snjeza @gayanper @fbricon