Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use recovered method symbol #539

Conversation

datho7561
Copy link

Needed to use reflection to access the field containing the recovered symbol.

  • Fixes "Remove argument", "Add parameter", "Qualify with enclosing type" quick fixes for the following snippet:
package io.github.datho7561;

public class MyCoolCodeActions {
	public void run(int i) {

	}
	public void foo() {
		new Runnable() {
			void run() {
				run(1);
			}
		}
	}
}
  • Should fix UnresolvedMethodsQuickFixTest.testMethodInAnonymousCovering1 in jdt-ls test suite

@datho7561
Copy link
Author

I think it will fix all UnresolvedMethodsQuickFixTest.testMethodInAnonymousCovering*

@datho7561 datho7561 force-pushed the dom-with-javac-unimplemented-getkey-codeaction branch from 0740c88 to 82a1ac1 Compare June 28, 2024 13:03
Needed to use reflection to access the field containing the recovered
symbol.

- Fixes "Remove argument", "Add parameter", "Qualify with enclosing
  type" quick fixes for the following snippet:

```java
package io.github.datho7561;

public class MyCoolCodeActions {
	public void run(int i) {

	}
	public void foo() {
		new Runnable() {
			void run() {
				run(1);
			}
		}
	}
}
```

- Should fix `UnresolvedMethodsQuickFixTest.testMethodInAnonymousCovering1` in jdt-ls test suite

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 force-pushed the dom-with-javac-unimplemented-getkey-codeaction branch from 82a1ac1 to 9710acf Compare July 2, 2024 16:01
@datho7561 datho7561 merged commit 3ddaf6d into eclipse-jdtls:dom-with-javac Jul 2, 2024
2 of 4 checks passed
@datho7561 datho7561 deleted the dom-with-javac-unimplemented-getkey-codeaction branch July 2, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant