Prevent caching outdated AST in CoreASTProvider (#2714)

Attempt to prevent caching outdated AST in CoreASTProvider Signed-off-by: Odin Dahlström <zerodind@gmail.com>
eclipse-jdtls · Jul 20, 2023 · c22b229 · c22b229
1 parent 9c2a29d
commit c22b229
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/...t.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/BaseDocumentLifeCycleHandler.java b/...t.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/BaseDocumentLifeCycleHandler.java
@@ -426,7 +426,13 @@ public ICompilationUnit handleChanged(DidChangeTextDocumentParams params) {
 
 		try {
 			if (unit.equals(sharedASTProvider.getActiveJavaElement())) {
+				// We call clearReconciliation here in an attempt to prevent getAST calls on other threads
+				// from caching outdated AST after we just called disposeAST. See also:
+				// https://github.com/eclipse/eclipse.jdt.ls/issues/1918
+				// https://github.com/eclipse/eclipse.jdt.ls/pull/2714#discussion_r1234817900
+				sharedASTProvider.clearReconciliation();
 				sharedASTProvider.disposeAST();
+				sharedASTProvider.clearReconciliation();
 				CodeActionHandler.codeActionStore.clear();
 			}