-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for skipping propagation of TextEdit #2312
Comments
Looks like the server only supports https://github.com/eclipse/eclipse.jdt.ls/blob/c9a2d051fc084f2d658c7326956c9698d12bee46/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/InitHandler.java#L180 currently. So we send the full text document on open, and incremental updates on changes. There's an option for |
Support for TextDocumentSyncKind.None seems to be the proper approach. It might actually require some updates on client side as well, but it's worth doing things proper. |
Current workaround: mickaelistria@57e38e3 |
Suggested #2423 |
Related PR: #2522 |
Fixed with #2522 |
I'm trying to use JDT-LS directly inside the Eclipse IDE, as a thread (same VM, same workspace, same JDT-Core...).
When editing the document in the IDE, the change is then sent to the LS as a
didChange
notification. JDT-LS assumes it owns the document thus it transform the change back into a document edit and re-applies it; then the document receives a change notification and LSP4E will then send a newdidChange
for it, then JDT-LS re-applies the change on the doc, then...The text was updated successfully, but these errors were encountered: