Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use SmartImport API #47

Closed
mickaelistria opened this issue Jul 13, 2016 · 6 comments
Closed

use SmartImport API #47

mickaelistria opened this issue Jul 13, 2016 · 6 comments

Comments

@mickaelistria
Copy link
Contributor

Eclipse Platform has a generic way to get started with a project, able to consume existing metadata to generate Eclipse ones, and to whom m2e, builship, jdt can contribute via extensions to detect and configure different kinds of projects.
This could be used instead of Maven-specifi importer.

@dmegert
Copy link

dmegert commented Jul 13, 2016

Sounds good, but for that, SmartImport first needs to move the Core part to a headless bundle.

@tsmaeder
Copy link
Contributor

Do we need to know where the project directory is for the smart import to work? People might not open the appropriate folder in VSCode

@mickaelistria
Copy link
Contributor Author

yes, you usually need the root directory. AFAIK, there is no mechanism for that in Eclipse Platform at the moment, however, it was considered with very similar goals: https://bugs.eclipse.org/bugs/show_bug.cgi?id=489799

@gorkem
Copy link
Contributor

gorkem commented Sep 5, 2016

@mickaelistria Is there an issue for moving the core SmartImport to a headless bundle?

@mickaelistria
Copy link
Contributor Author

@gorkem Yes, SmartImport is API, so we cannot move it anymore at the moment. However, we can "copy" it someplace else and make the current API extend or delegate to the one in a non-UI bundle.
Please open an enhancement request against Platform UI for that as it will require some discussion to take the best decisions.

@gorkem gorkem closed this as completed in 5cab6aa Oct 17, 2016
@gorkem gorkem reopened this Oct 17, 2016
yaohaizh pushed a commit to yaohaizh/eclipse.jdt.ls that referenced this issue Aug 31, 2017
Signed-off-by: Fred Bricon <fbricon@gmail.com>
@gorkem gorkem added the wontfix label Nov 2, 2017
@gorkem
Copy link
Contributor

gorkem commented Nov 2, 2017

Implemented as the new importers.

@gorkem gorkem closed this as completed Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants