Fix semantic tokens offset due to document updates #1552
Conversation
Signed-off-by: 0dinD <zerodind@gmail.com>
| return new SemanticTokens(Collections.emptyList()); | ||
| } | ||
|
|
||
| SemanticTokensVisitor collector = new SemanticTokensVisitor(root, SemanticTokenManager.getInstance()); |
There was a problem hiding this comment.
Looks good. But not sure whether it can fix the problem completely.
As my understanding, both document and CompilationUnit are a snapshot of the document at some point. The difference is CompilationUnit is the AST tree parsed from the document at some point. I'm curious how the fix can guarantee it's not out-of-sync.
There was a problem hiding this comment.
Yes, the compilation unit might get out-of-sync with the real document at some points. But the problem before this change was that the semantic token visitor used both a document and AST nodes from the compilation unit, and the document was not in sync with the compilation unit.
There was a problem hiding this comment.
Actually I just submitted redhat-developer/vscode-java#1632, which should fix the problem that you've pointed out. It turns out that there were two separate issues causing the offset, see my comment.
|
@0dinD This PR looks promising, good job! As you know it's not easy for me to reproduce the issue, so I'd like to use it in my working projects for a while, and see if we do get rid of the issue. I'll let you know my feedback then. |
|
@Eskibear sounds like a good idea! Don't forget to also use redhat-developer/vscode-java#1632. |
|
@Eskibear if it helps, here are some gifs showing the best way I can reproduce the issue: Part one of the issue: (fixed by this PR) Part two of the issue: (fixed by redhat-developer/vscode-java#1632) If you're wondering what I mean by "part one" and "part two", see my issue comment. |
|
PR LGTM. I'll let @Eskibear merge it once he's done testing it. |
There was a problem hiding this comment.
LGTM.
I've played it for in my project for one day or two, and so far it worked well. And I also tried the way metioned in #1552 (comment) , I cannot reproduce it now. 👍
Fixes part of redhat-developer/vscode-java#1597.
See redhat-developer/vscode-java#1632 for the second part of the fix.
This is done by getting the token line and column number directly from its compilation unit, rather than the document, which for whatever reason gets out-of-sync during frequent updates.