Don't call System.exit on exit, might cause workspace corruption #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rerun tests |
gorkem
approved these changes
Mar 28, 2017
| System.exit(0); | ||
| Executors.newSingleThreadScheduledExecutor().schedule(() -> { | ||
| logInfo("Forcing exit after 1 min."); | ||
| System.exit(0); |
There was a problem hiding this comment.
wonder if we should return a value other than 0 in this case. It is not actually a clear exit.
There was a problem hiding this comment.
agreed. exit code 1?
There was a problem hiding this comment.
OK, Let's define it as a constant though.
Signed-off-by: Fred Bricon <fbricon@gmail.com>
fbricon
force-pushed
the
bad-system-exit
branch
from
1b7fb72
to
86fd7a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Fred Bricon fbricon@gmail.com