Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update org.eclipse.jdt.ls.tp.target to use m2e snapshot #2563

Merged
merged 2 commits into from
Mar 31, 2023
Merged

Conversation

Eskibear
Copy link
Contributor

Maven 3.9.1 is embedded in latest m2e snapshot build, which enables jdtls to resolve dependencies in parallel.

@Eskibear
Copy link
Contributor Author

See eclipse-m2e/m2e-core#1169 (comment) and eclipse-m2e/m2e-core#1238

@rgrunber rgrunber added this to the Early April 2023 milestone Mar 30, 2023
@rgrunber
Copy link
Contributor

rgrunber commented Mar 30, 2023

Looks like the next release would be 2.3.0 (I don't think 2.2.2 would have the change), which is fine. Just wanted to confirm we aren't moving to a snapshot of something that will be 3.x, as that might force us to have to adapt to a lot more breaking changes.

@Eskibear
Copy link
Contributor Author

Yes, now snapshots/latest points to snapshots/2.3.0. In order not to wrongly use 3.x, I thought we would switch to releases/2.3.0 once it's released. Do you want me to explicitly change it to 2.3.0? I'm ok with both.

Copy link
Contributor

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually yes, that's probably better to do. Just use snapshots/2.3.0/. Once that's in, feel free to merge.

@Eskibear Eskibear merged commit 2f15305 into master Mar 31, 2023
@Eskibear Eskibear deleted the yanzh/mvn391 branch March 31, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants