Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt automatic JVM detection on startup #2731

Merged
merged 1 commit into from Jun 27, 2023

Conversation

rgrunber
Copy link
Contributor

@rgrunber rgrunber commented Jun 27, 2023

  • Update target platform to I20230615-1800

See eclipse-jdt/eclipse.jdt.debug#230

When the following command request is made :

{
  message: "[Trace - 11:25:11] Sending request 'workspace/executeCommand - (9)'.",
  level: 'info',
  timestamp: '2023-06-27 11:25:11.077'
}
{
  message: 'Params: {\n' +
    '    "command": "java.project.getSettings",\n' +
    '    "arguments": [\n' +
    '        "file:///home/rgrunber/sample-projects/null-analysis-app/",\n' +
    '        [\n' +
    '            "org.eclipse.jdt.core.compiler.source",\n' +
    '            "org.eclipse.jdt.ls.core.vm.location"\n' +
    '        ]\n' +
    '    ]\n' +
    '}\n' +
    '\n',
  level: 'info',
  timestamp: '2023-06-27 11:25:11.077'
}

The response for "org.eclipse.jdt.ls.core.vm.location" is something like :
"/usr/lib/jvm/java-11-openjdk-11.0.19.0.7-1.fc37.x86_64"
instead of :
"/usr/lib/jvm/java-17-openjdk-17.0.7.0.7-5.fc37.x86_64".

This assumes a JVM from the system can be detected and that "org.eclipse.jdt.core.compiler.source": "11" is detected from the build configuration.

- Update target platform to I20230625-1800

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
@rgrunber rgrunber added this to the End June 2023 milestone Jun 27, 2023
@rgrunber rgrunber merged commit 1cd21c6 into eclipse-jdtls:master Jun 27, 2023
6 checks passed
@rgrunber rgrunber deleted the update-tp branch June 27, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant