Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable call hierarchy implementors #2792

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gayanper
Copy link
Contributor

@gayanper gayanper commented Aug 8, 2023

Fixes #2780

@gayanper
Copy link
Contributor Author

gayanper commented Aug 8, 2023

@rgrunber WDYT ?

  • Should we add a new preference for this ?
  • Do we need any UI indication like adding some prefix to the symbol name or details ?

@gayanper gayanper marked this pull request as ready for review September 5, 2023 17:26
@gayanper
Copy link
Contributor Author

gayanper commented Sep 5, 2023

@jdneo @rgrunber @jjohnstn @testforstephen What do you think ?

@gayanper
Copy link
Contributor Author

@jdneo @rgrunber @jjohnstn @testforstephen @snjeza Any feedback ?

@rgrunber
Copy link
Contributor

Any comments on #2780 (comment) ?

Copy link
Contributor

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, assuming we're fine with the workflow there's just one case I don't understand.

If I perform an outgoing call hierarchy on fetchName(int) (from the example) I see the following, once I expeand get(int) : E - java.util.List

image

Is this claiming that java.util.Vector's get(int) (at the bottom) declaration has an outgoing call to contains(Object) because I don't see that when I look into the get(int) declaration.

Also, if I perform outgoing call hierarchy directly on java.util.List's get(int) I don't see any of the above entries. Is this intended ?

@rgrunber
Copy link
Contributor

rgrunber commented Jan 9, 2024

@gayanper , this should be fine to merge. Just curious about the questions I had in the comment above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for callees based on implementors
2 participants