New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable call hierarchy implementors #2792
base: master
Are you sure you want to change the base?
Conversation
@rgrunber WDYT ?
|
@jdneo @rgrunber @jjohnstn @testforstephen What do you think ? |
@jdneo @rgrunber @jjohnstn @testforstephen @snjeza Any feedback ? |
Any comments on #2780 (comment) ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, assuming we're fine with the workflow there's just one case I don't understand.
If I perform an outgoing call hierarchy on fetchName(int)
(from the example) I see the following, once I expeand get(int) : E - java.util.List
Is this claiming that java.util.Vector
's get(int)
(at the bottom) declaration has an outgoing call to contains(Object)
because I don't see that when I look into the get(int)
declaration.
Also, if I perform outgoing call hierarchy directly on java.util.List
's get(int)
I don't see any of the above entries. Is this intended ?
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/preferences/PreferenceManager.java
Outdated
Show resolved
Hide resolved
556e7dd
to
7237c0e
Compare
@gayanper , this should be fine to merge. Just curious about the questions I had in the comment above. |
Fixes #2780