Consider token to limit the chains that are searched #2835
Conversation
|
@rgrunber @jdneo @testforstephen @snjeza what do you think about this change ? |
|
We could increase this, but as mentioned in #2730 (comment), I think we'll be limited by the performance of the chain search. Increasing the maximum chains might not necessarily mean more chains if we're always hitting the timeout, and returning no results. Part of the reason I kept it so small, is I felt there would be a limited number of chains that are useful. |
|
I will have a look at that root cause to see if we can improve the type resolution over there in jdt. |
gayanper
force-pushed
the
increase-context-chain-size
branch
from
ef32135
to
79642ad
Compare
gayanper
changed the title
|
@rgrunber Can you check my new way of tackling the same issue ? if it looks good, I can add the changes to jdt chain finder and use it in JDT LS, while we keep that open for JDT project adapt if there is any contributor for JDT.UI. |
...e.jdt.ls.tests/src/org/eclipse/jdt/ls/core/internal/handlers/CompletionHandlerChainTest.java
Outdated
Show resolved
Hide resolved
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/contentassist/ChainFinder.java
Outdated
Show resolved
Hide resolved
What if we make the token match case insensitive and let the completion filter handle the rest ? So if I type |
|
@rgrunber WDYT about latest changes ? If this looks good, would you prefer adding this changes to jdt.ui or should we keep a copy of ChainFinder in jdt.ls and evolve further here ? |
- simplify the code by reusing CompletionProposalRequestor to create items - add support for javadoc for chain completions
gayanper
force-pushed
the
increase-context-chain-size
branch
from
c02861e
to
c214002
Compare
gayanper
force-pushed
the
increase-context-chain-size
branch
from
c214002
to
a0d6d1e
Compare
|
Could we use |
|
Depends on eclipse-jdt/eclipse.jdt.ui#1282 |
This draft use a copy of ChainFinder to tryout using token to limit the number of chain produced by the the chain finder. Instead of increasing the chain size which could potentially go into more deeper search, this approach provides the capability to user to filter by the token to find the most relevant chains the user is searching for.