Avoid refreshing bundles whose dependency closure includes JDT-LS.

[snjeza]

Fixes redhat-developer/vscode-java#3349

[rgrunber]

Overall, this seems to fix the issue! Just wouldn't mind having a closer look.

I was reproducing this (using VS Code) by making sure vscode-pde was installed, and then applying the following patch to JDT-LS :

diff --git a/org.eclipse.jdt.ls.product/languageServer.product b/org.eclipse.jdt.ls.product/languageServer.product
index 3b97b4ff..4389cb7e 100644
--- a/org.eclipse.jdt.ls.product/languageServer.product
+++ b/org.eclipse.jdt.ls.product/languageServer.product
@@ -66,6 +66,7 @@
       <plugin id="org.eclipse.osgi.services"/>
       <plugin id="org.eclipse.text"/>
       <plugin id="org.eclipse.xtext.xbase.lib"/>
+      <plugin id="org.eclipse.team.core"/>
    </plugins>
 
    <configurations>

The first time it would always fail. Afterwards, I assume it'd succeed because the team.core bundle from vscode-pde got properly detected by the framework, hence the singleton warnings. I would then reproduce the behaviour by calling rm -rf server/config_linux/org.eclipse.* on the Equinox state files.

[snjeza]

@rgrunber I have updated the PR.

[rgrunber]

I would just update the commit message and error message. After that, feel free to merge. Can you make it :

Avoid refreshing bundles whose dependency closure includes JDT-LS.

Just a note, we might be able to keep track of this in the future since the logs mention the failure. It isn't harmful though as the exception gets caught and doesn't break initialization.