Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid unnecessary project updates #2987

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Avoid unnecessary project updates #2987

merged 1 commit into from
Dec 5, 2023

Conversation

snjeza
Copy link
Contributor

@snjeza snjeza commented Dec 5, 2023

@rgrunber rgrunber added this to the End December 2023 milestone Dec 5, 2023
rgrunber
rgrunber reviewed Dec 5, 2023
View reviewed changes
Copy link
Contributor

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a regression from #2976 then ? Is this just preventing updateProject(..) from being called once to update the JAVALS_PROFILE and again if any of the mojo settings are updated ?

....jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/preferences/StandardPreferenceManager.java Show resolved Hide resolved
@rgrunber rgrunber changed the title [performance] Avoid unnecessary project updates Avoid unnecessary project updates Dec 5, 2023
@snjeza
Copy link
Contributor Author

snjeza commented Dec 5, 2023

This is just a regression from #2976 then ? Is this just preventing updateProject(..) from being called once to update the JAVALS_PROFILE and again if any of the mojo settings are updated

There was the issue when java.import.maven.disableTestClasspathFlag was set.

@rgrunber rgrunber merged commit 44ccab8 into eclipse-jdtls:master Dec 5, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgrunber rgrunber rgrunber left review comments

@fbricon fbricon Awaiting requested review from fbricon

@jdneo jdneo Awaiting requested review from jdneo

@testforstephen testforstephen Awaiting requested review from testforstephen

Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
Early December 2023
Development

Successfully merging this pull request may close these issues.

Infinite loading after update to 1.25.0
2 participants
@snjeza @rgrunber