Fix multiline semantic highlighting for 'implements', 'extends', and 'permits' keywords #2995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please. |
rgrunber
reviewed
Dec 8, 2023
...e.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/semantictokens/SemanticTokensVisitor.java
Show resolved
Hide resolved
|
If we can also do |
hopehadfield
force-pushed
the
implements-highlight
branch
from
1215bed
to
a1cb9e1
Compare
hopehadfield
changed the title
rgrunber
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
The permits works well for me now. I guess we can live with guarding off the token so it's only added when the execution environment is Java >= 17 since that's when sealed types were finalized. With that said I don't think it'd be that bad to support it even if a user mistakenly types it. The validation would still inform them the token is not supported.
Last thing is to just add a testcase for sealed classes.
…'permits' keywords Signed-off-by: Hope Hadfield <hhadfiel@redhat.com>
hopehadfield
force-pushed
the
implements-highlight
branch
from
a1cb9e1
to
91ce92d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2920 (comment)
Before:
After:
