Update target platform to 2023-12 state

[akurtakov]

No description provided.

[rgrunber]

Looks like it should be fine :

3rd party libraries

plugins/com.google.guava_32.1.2.jre.jar
    plugins/com.google.guava_32.1.3.jre.jar

plugins/com.google.guava.failureaccess_1.0.1.jar
    plugins/com.google.guava.failureaccess_1.0.2.jar

plugins/javax.annotation_1.3.5.v20200909-1856.jar
plugins/javax.inject_1.0.0.v20220405-0441.jar
    plugins/jakarta.annotation-api_1.3.5.jar
    plugins/jakarta.inject.jakarta.inject-api_1.0.5.jar

plugins/org.apache.commons.cli_1.5.0.jar
    plugins/org.apache.commons.cli_1.6.0.jar

plugins/org.apache.commons.lang3_3.8.1.jar
    plugins/org.apache.commons.lang3_3.14.0.jar

plugins/org.eclipse.m2e.apt.core_2.2.100.20230520-0934.jar
    plugins/org.eclipse.m2e.apt.core_2.2.200.20231119-0901.jar

plugins/org.eclipse.m2e.core_2.4.0.20230826-0915.jar
    plugins/org.eclipse.m2e.core_2.4.1.20231119-0901.jar

plugins/org.eclipse.m2e.jdt_2.3.2.20230823-0832.jar
    plugins/org.eclipse.m2e.jdt_2.3.3.20231119-0901.jar

plugins/org.eclipse.m2e.maven.runtime_3.9.400.20230826-0755.jar
    plugins/org.eclipse.m2e.maven.runtime_3.9.500.20231113-2345.jar

plugins/org.eclipse.xtext.xbase.lib_2.32.0.v20230827-1315.jar
    plugins/org.eclipse.xtext.xbase.lib_2.33.0.v20231121-0955.jar

[rgrunber]

This breaks developing JDT-LS in Eclipse (vscode-pde succeeds by wrongly using 3.13.0 which tells me maybe this is related to the fix that ensured non-IU artifacts would be checked).

The target platform works fine through Tycho, but PDE complains about finding the bundle even though it looks to have been downloaded in the local Maven repository.

Current workaround (it falls back to 3.13 from the platform) :

diff --git a/org.eclipse.jdt.ls.target/org.eclipse.jdt.ls.tp.target b/org.eclipse.jdt.ls.target/org.eclipse.jdt.ls.tp.target
index 3bfe464a..0706c489 100644
--- a/org.eclipse.jdt.ls.target/org.eclipse.jdt.ls.tp.target
+++ b/org.eclipse.jdt.ls.target/org.eclipse.jdt.ls.tp.target
@@ -37,12 +37,6 @@
         </location>
            <location includeDependencyDepth="none" includeDependencyScopes="compile" includeSource="true" missingManifest="generate" type="Maven">
                    <dependencies>
-                           <dependency>
-                                   <groupId>org.apache.commons</groupId>
-                                   <artifactId>commons-lang3</artifactId>
-                                   <version>3.14.0</version>
-                                   <type>jar</type>
-                           </dependency>
                            <dependency>
                                    <groupId>commons-codec</groupId>
                                    <artifactId>commons-codec</artifactId>
@@ -63,4 +57,4 @@
            </location>
     </locations>
     <targetJRE path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-17"/>
-</target>
+</target>
\ No newline at end of file

[akurtakov]

@rgrunber I can't reproduce

.
Do you use Eclipse 2023-12 ?

[rgrunber]

Yup, Version: 2023-12 (4.30). I even tried starting with a fresh workspace and cleaned out the local repository. Same problem.

[snjeza]

@rgrunber Could you try to remove

• ~/.m2/repository/org/eclipse/orbit/bundles/org.apache.commons.lang3
• ~/.m2/repository/org/apache/commons/commons-lang3
• ~/.m2/repository/p2/osgi/bundle/org.apache.commons.lang3
• ~/.m2/repository/.cache/tycho/
• ~/.m2/repository/.meta/

[akurtakov]

@snjeza Does it resolve fine for you?

[snjeza]

Does it resolve fine for you?

@akurtakov Yes, It does.

[rgrunber]

@rgrunber Could you try to remove

* ~/.m2/repository/org/eclipse/orbit/bundles/org.apache.commons.lang3

* ~/.m2/repository/org/apache/commons/commons-lang3

* ~/.m2/repository/p2/osgi/bundle/org.apache.commons.lang3

* ~/.m2/repository/.cache/tycho/

* ~/.m2/repository/.meta/

I have tried completely removing ~/.m2/repository, a fresh 4.30 (with install of m2e pde integration), with a new clone of JDT-LS. It still occurs.

[rgrunber]

This actually works for me. So 3.13.0 works and resolves from the local repo, but not 3.14.0.

diff --git a/org.eclipse.jdt.ls.target/org.eclipse.jdt.ls.tp.target b/org.eclipse.jdt.ls.target/org.eclipse.jdt.ls.tp.target
index 90ac95b4..f189d9ba 100644
--- a/org.eclipse.jdt.ls.target/org.eclipse.jdt.ls.tp.target
+++ b/org.eclipse.jdt.ls.target/org.eclipse.jdt.ls.tp.target
@@ -40,7 +40,7 @@
                            <dependency>
                                    <groupId>org.apache.commons</groupId>
                                    <artifactId>commons-lang3</artifactId>
-                                   <version>3.14.0</version>
+                                   <version>3.13.0</version>
                                    <type>jar</type>
                            </dependency>
                            <dependency>

[snjeza]

@rgrunber Could you try the following:

• Windows>Preferences>Plug-in Development>Target Platform
• select Java Language Server Target Platform
• click Edit
• wait for Eclipse to load the plugins
• click Reload

[rgrunber]

I did. #2998 (comment) is a view for the target platform editor. It fails to load all the plugins once it fails on commons-lang3. If I click "Refresh" from there, the issue remains. If I click "Finish" and then "Reload", I just get an error to load all the other features/plugins that were never reached because of the failure to load commons-lang3.

[rgrunber]

A recent I-build (I20231212-1800) of Eclipse SDK (that should include a version of PDE Core with the fix referenced) fixes the problem for me.