Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new headless quick fixes upstream for string concatenation #3007

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

gayanper
Copy link
Contributor

Add support for following conventions

  • String To MessageFormat
  • String To Buffer|Builder
  • String To String.format

@gayanper
Copy link
Contributor Author

@jjohnstn you can have a look at this after the upstream is merged

@gayanper gayanper marked this pull request as ready for review January 4, 2024 19:31
@gayanper
Copy link
Contributor Author

gayanper commented Jan 5, 2024

@jjohnstn the PR is ready now

@rgrunber
Copy link
Contributor

rgrunber commented Jan 8, 2024

Just to confirm, this takes advantage of eclipse-jdt/eclipse.jdt.ui#1032 ?

@rgrunber rgrunber changed the title Add support for new headless quick fixes from upstream fro string concatenation Add support for new headless quick fixes upstream for string concatenation Jan 8, 2024
@rgrunber rgrunber self-requested a review January 8, 2024 15:58
@rgrunber rgrunber added this to the Early January 2024 milestone Jan 8, 2024
@gayanper
Copy link
Contributor Author

gayanper commented Jan 8, 2024

Just to confirm, this takes advantage of eclipse-jdt/eclipse.jdt.ui#1032 ?

Yes

@rgrunber rgrunber merged commit 2b9a044 into eclipse-jdtls:master Jan 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants