Migrate ReorgCorrections, TypeMismatch, UnresolvedElements sub processors #3045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robstryker
force-pushed
the
ConsumeSubProcessorsPart2
branch
from
e13bccc
to
0add9c5
Compare
|
See https://ci.eclipse.org/ls/job/jdt-ls-pr/4973/testReport/ . I had about the same number of failures locally. |
robstryker
force-pushed
the
ConsumeSubProcessorsPart2
branch
from
0add9c5
to
b475056
Compare
…ocTags sub processors Signed-off-by: Rob Stryker <rob@oxbeef.net> Update tp and fix test errors Signed-off-by: Rob Stryker <rob@oxbeef.net>
robstryker
force-pushed
the
ConsumeSubProcessorsPart2
branch
from
b41875b
to
97097f2
Compare
rgrunber
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
I've tested (I think) all of the code actions within ReorgCorrections, TypeMismatch but there's just too many in UnresolvedElements. I'm gonna trust the testcases on that one.
I haven't found any errors. It all seems to work as before.
Fun fact. I did run into eclipse-jdt/eclipse.jdt.ui#184 because apparently we have copied code from QuickAssistProcessor that wasn't updated to include that fix but that's another issue.
rgrunber
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.