Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE when fetching the classpath of the project #3115

Merged
merged 1 commit into from Mar 31, 2024

Conversation

jdneo
Copy link
Contributor

@jdneo jdneo commented Mar 27, 2024

When the path of the lib classpath entry points to a file which does not exist on file system, .getLocation() could return null.

Signed-off-by: Sheng Chen <sheche@microsoft.com>
@jdneo
Copy link
Contributor Author

jdneo commented Mar 28, 2024

test this please

Copy link
Contributor

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with merging if it fixes the issue. I just noticed a slight issue, but not sure if it causes a separate bug.

@jdneo jdneo merged commit ae10481 into eclipse-jdtls:master Mar 31, 2024
7 checks passed
@jdneo jdneo deleted the cs/fix-npe branch March 31, 2024 01:36
@rgrunber rgrunber added this to the End March 2024 milestone Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants