Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Web project wizard to always add a Java library. #7

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

davenice
Copy link
Contributor

Suggested fix for https://bugs.eclipse.org/bugs/show_bug.cgi?id=580990 - adding a Java library by default.

If there's a more standard correlation between Java version and Web facet version beyond 4.0 then I'm happy to update the PR to match.

@davenice davenice marked this pull request as draft March 13, 2024 11:39
@davenice davenice marked this pull request as ready for review March 13, 2024 11:58
@erik-brangs
Copy link
Contributor

Servlet 5.0 requires Java 8 (source). Servlet 6.0 requires Java 11 (source).

Copy link
Contributor

@erik-brangs erik-brangs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message should mention the bug, e.g. "Bug 580990 - Update Web project wizard to always add a Java library" .

@nitind nitind merged commit 4dfcf46 into eclipse-jeetools:master Mar 14, 2024
1 check passed
@nitind
Copy link
Contributor

nitind commented Mar 14, 2024

Many thanks, Dave (and it's a little cleaner than the version I'd readied, too).

@davenice davenice deleted the patch-1 branch March 14, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants