test : Update Spring boot tests for layered jar changes #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that when we merge this feature, it'll be better to have an additional test |
rohanKanojia
force-pushed
the
pr/spring-boot-layered
branch
8 times, most recently
from
07b0436
to
4055b65
Compare
rohanKanojia
force-pushed
the
pr/spring-boot-layered
branch
2 times, most recently
from
d9f34c4
to
869b977
Compare
manusa
reviewed
Aug 30, 2023
| import static org.hamcrest.Matchers.hasSize; | ||
|
|
||
| @KubernetesTest(createEphemeralNamespace = false) | ||
| public class ZeroConfigFatJar implements JKubeCase, MavenCase { |
There was a problem hiding this comment.
I'm assuming this is because Spring is less than x version. right?
There was a problem hiding this comment.
You're right. I've updated PR description
rohanKanojia
force-pushed
the
pr/spring-boot-layered
branch
2 times, most recently
from
eb23434
to
a998b72
Compare
+ Remove spring boot dependencies from dependencyManagement in parent pom. Spring boot projects would not use spring-boot.version property explicitly in poms + Add ZeroConfigFatJarK8sITCase to verify kubernetes maven plugin workflow in case of spring boot projects that don't generate a layered jar Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
force-pushed
the
pr/spring-boot-layered
branch
from
a998b72
to
24add42
Compare
manusa
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to eclipse-jkube/jkube#2309
spring.versionconstant instead of inheriting version from dependencyManagementzero-config-fatjarintegration test spring project that will usespring-boot.fat-jar.version(2.3.9.RELEASE). Till this release, spring boot generated fat jars by default.Signed-off-by: Rohan Kumar rohaan@redhat.com